Skip to content

fix(linter): let file-header disable directives suppress file-start diagnostics#19283

Draft
camc314 wants to merge 2 commits intomainfrom
c/02-11-fix_linter_let_file-header_disable_directives_suppress_file-start_diagnostics
Draft

fix(linter): let file-header disable directives suppress file-start diagnostics#19283
camc314 wants to merge 2 commits intomainfrom
c/02-11-fix_linter_let_file-header_disable_directives_suppress_file-start_diagnostics

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Feb 11, 2026

cloese #19528

Copy link
Contributor Author

camc314 commented Feb 11, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Feb 11, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 11, 2026

Merging this PR will not alter performance

✅ 47 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing c/02-11-fix_linter_let_file-header_disable_directives_suppress_file-start_diagnostics (ce31e3f) with main (79fc6d7)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camc314 camc314 force-pushed the c/02-11-fix_linter_let_file-header_disable_directives_suppress_file-start_diagnostics branch from 5295d2a to adaeec9 Compare February 11, 2026 20:44
@github-actions github-actions bot added A-cli Area - CLI A-linter-plugins Area - Linter JS plugins labels Feb 11, 2026
@camc314 camc314 changed the base branch from main to graphite-base/19283 February 11, 2026 20:48
@camc314 camc314 force-pushed the graphite-base/19283 branch from 8bef2c3 to 8be7b4d Compare February 11, 2026 20:48
@camc314 camc314 force-pushed the c/02-11-fix_linter_let_file-header_disable_directives_suppress_file-start_diagnostics branch from adaeec9 to 5c23326 Compare February 11, 2026 20:48
@camc314 camc314 changed the base branch from graphite-base/19283 to c/02-11-test_linter_add_option_to_pass_custom_arguments February 11, 2026 20:49
@camc314 camc314 force-pushed the c/02-11-test_linter_add_option_to_pass_custom_arguments branch from 8be7b4d to 4f5959b Compare February 12, 2026 11:42
@camc314 camc314 force-pushed the c/02-11-fix_linter_let_file-header_disable_directives_suppress_file-start_diagnostics branch from 5c23326 to 1b5360e Compare February 12, 2026 11:42
@camc314 camc314 force-pushed the c/02-11-test_linter_add_option_to_pass_custom_arguments branch from 4f5959b to 1635eac Compare February 12, 2026 11:43
@camc314 camc314 force-pushed the c/02-11-fix_linter_let_file-header_disable_directives_suppress_file-start_diagnostics branch from 1b5360e to ed3963d Compare February 12, 2026 11:43
@graphite-app graphite-app bot changed the base branch from c/02-11-test_linter_add_option_to_pass_custom_arguments to graphite-base/19283 February 12, 2026 15:55
Copy link
Contributor

@wagenet wagenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this should fix the issue I saw!

@camc314 camc314 force-pushed the graphite-base/19283 branch from 1635eac to 3a6059f Compare February 13, 2026 12:31
@camc314 camc314 force-pushed the c/02-11-fix_linter_let_file-header_disable_directives_suppress_file-start_diagnostics branch from 7147746 to 42979ab Compare February 13, 2026 12:31
@camc314 camc314 changed the base branch from graphite-base/19283 to main February 13, 2026 12:31
@camc314 camc314 force-pushed the c/02-11-fix_linter_let_file-header_disable_directives_suppress_file-start_diagnostics branch 3 times, most recently from 0e1f73d to f0a30bc Compare February 13, 2026 12:53
@camc314 camc314 force-pushed the c/02-11-fix_linter_let_file-header_disable_directives_suppress_file-start_diagnostics branch from f0a30bc to 070b32e Compare February 19, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants